Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #234

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update docs #234

merged 3 commits into from
Nov 21, 2024

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Nov 20, 2024

Adding a bunch of docs to the README.

Let me know if you can think of any other features/use cases that we should cover.

corymhall added a commit that referenced this pull request Nov 20, 2024
This adds a new environment variable flag
`PULUMI_CDK_EXPERIMENTAL_LOOKUPS` that enables CDK lookups during
preview operations.

I am working on adding the documentation in a follow up PR #234

re #184
@corymhall corymhall force-pushed the corymhall/update-docs-2 branch from 7dd6c0e to adf3e76 Compare November 20, 2024 16:18
@corymhall corymhall marked this pull request as ready for review November 20, 2024 16:20
@corymhall corymhall self-assigned this Nov 20, 2024
corymhall added a commit that referenced this pull request Nov 20, 2024
This adds a new environment variable flag
`PULUMI_CDK_EXPERIMENTAL_LOOKUPS` that enables CDK lookups during
preview operations.

I am working on adding the documentation in a follow up PR #234

re #184
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some minor comments

README.md Outdated
});
```

### L2 Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does L2 exactly stand for in this case?
It seems like the test is importing a CDK resource created by the pulumi provider, what is L2 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case "importing" more accurately means "casting". CDK L2s do not take string values, they take references to other L2s. This example shows how you can take a Pulumi resource, turn it into a CDK L2 (via fromXXX methods) and pass that as an argument to an L2.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
## Use Pulumi resources with CDK Constructs

It is possible to use Pulumi and CDK resources side-by-side. In order to pass a
Pulumi Output value into a CDK resource you can use the [asString][./api-docs/README.md#asString], [asList][./api-docs/README.md#asList], &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asList seems to only handle lists of strings, do we ever need to pass objects? Interetssing.

README.md Outdated Show resolved Hide resolved
@@ -160,7 +637,9 @@ create the following staging resources.

See [API Docs](./api-docs/README.md) for more details.

## Building locally
## Contributing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md probably, this README is getting big.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave this as a todo. I'll tackle creating a true contributing guide as a separate thing.

@t0yv0 t0yv0 self-requested a review November 21, 2024 17:42
@corymhall corymhall force-pushed the corymhall/update-docs-2 branch from adf3e76 to 39d0185 Compare November 21, 2024 20:22
@corymhall corymhall enabled auto-merge (squash) November 21, 2024 20:24
@corymhall corymhall merged commit 452aac2 into main Nov 21, 2024
13 checks passed
@corymhall corymhall deleted the corymhall/update-docs-2 branch November 21, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants