Add experimental flag for enabling CDK lookups #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
reviewed
Nov 20, 2024
| try { | ||
| // TODO: support lookups https://github.com/pulumi/pulumi-cdk/issues/184 | ||
| await cli.synth({ quiet: true, lookups: false }); | ||
| await cli.synth({ quiet: true, lookups }); |
There was a problem hiding this comment.
I think that's fine assuming we document that folks cannot add pulumi resources in their stacks
There was a problem hiding this comment.
I just pushed a commit here that documents how this would work. Pretty much all apps will have pulumi resources due to the asset stuff.
| } catch (e: any) { | ||
| if (typeof e.message === 'string' && e.message.includes('Context lookups have been disabled')) { | ||
| const message = e.message as string; | ||
| const messageParts = message.split('Context lookups have been disabled. '); | ||
| const missingParts = messageParts[1].split('Missing context keys: '); | ||
| throw new Error( | ||
| 'Context lookups have been disabled. Make sure all necessary context is already in "cdk.context.json". \n' + | ||
| 'Context lookups have been disabled. Make sure all necessary context is already in "cdk.context.json". ' + |
There was a problem hiding this comment.
How would this look like for an app with multiple stacks (or multiple apps) in one repo? Does "cdk.context.json" contain the context for all of them?
There was a problem hiding this comment.
Yes cdk.context.json contains context for the entire app. It's currently not possible to have multiple apps.
flostadler
approved these changes
Nov 20, 2024
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new environment variable flag
PULUMI_CDK_EXPERIMENTAL_LOOKUPSthat enables CDK lookups during preview operations.I am working on adding the documentation in a follow up PR #234
re #184