Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for top 19/20 constructs #183

Closed
t0yv0 opened this issue Oct 28, 2024 · 1 comment · Fixed by #209
Closed

Add tests for top 19/20 constructs #183

t0yv0 opened this issue Oct 28, 2024 · 1 comment · Fixed by #209
Assignees
@corymhall
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.112

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 28, 2024 •
edited by corymhall
Loading

  1. iam
  • Group
  • InstanceProfile
  • Policy
  • Role
  • User
  • ManagedPolicy
  1. s3
  • Bucket
  • BucketPolicy
  1. lambda
  • Alias
  • Function
  • FunctionUrl
  • LayerVersion
  • Version
  1. logs
  • LogGroup
  • LogStream
  • LogStream
  • MetricFilter
  • QueryDefinition
  • ResourcePolicy
  • SubscriptionFilter
  1. events
  • Rule
  • EventBus
  • EventBusPolicy
  • Connection
  • Archive
  • ApiDestination
  1. ec2
  • ClientVpnAuthorizationRule
  • ClientVpnEndpoint
  • ClientVpnRoute
  • FlowLog
  • GatewayVpcEndpoint
  • Instance
  • InterfaceVpcEndpoint
  • KeyPair
  • LaunchTemplate
  • NetworkAcl
  • NetworkAclEntry
  • PlacementGroup
  • PrefixList
  • PrivateSubnet
  • PublicSubnet
  • SecurityGroup
  • Subnet
  • SubnetNetworkAclAssociation
  • Volume
  • Vpc
  • VpcEndpointService
  • VpnConnection
  • VpnGateway
  1. ssm
  • StringParameter
  1. dynamodb
  • Table
  • TableV2
  1. sns
  • Subscription
  • Topic
  • TopicPolicy
  1. apigateway
  • ApiKey
  • BasePathMapping
  • CognitoUserPoolsAuthorizer
  • Deployment
  • DomainName
  • GatewayResponse
  • LambdaRestApi
  • Method
  • Model
  • ProxyResource
  • RateLimitedApiKey
  • RequestAuthorizer
  • RequestValidator
  • Resource
  • RestApi
  • SpecRestApi
  • Stage
  • StepFunctionsRestApi
  • TokenAuthorizer
  • UsagePlan
  • VpcLink
  1. kms
  • Key
  • Alias
  1. sqs
  • Queue
  • QueuePolicy
  1. ecr
  • Repository
  1. route53

  • HostedZone

  • *Record (CfnRecordSet)

  • 15. custom_resources

  • 16. lambda_nodejs

  1. cloudfront
  • Function
  • OriginRequestPolicy
  • PublicKey
  • S3OriginAccessControl
  • ResponseHeadersPolicy
  • KeyValueStore
  • Distribution
  • CachePolicy
  • KeyGroup
  • OriginAccessIdentity
  • RealtimeLogConfig
  1. secretsmanager
  • ResourcePolicy
  • RotationSchedule
  • Secret
  • SecretRotation
  • SecretTargetAttachment
  1. cloudwatch
  • Alarm
  • CompositeAlarm
  • Dashboard
  1. Lambda_layer_awscli
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/2191

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 28, 2024
@corymhall corymhall removed the needs-triage Needs attention from the triage team label Oct 29, 2024
@mjeffryes mjeffryes added this to the 0.112 milestone Oct 30, 2024
corymhall added a commit that referenced this issue Nov 1, 2024
@corymhall
Add integration tests for ApiGateway
c4bb803 
This adds the first integration tests for ApiGateway. This will get us
to full coverage on ApiGateway constructs

re #183
@corymhall corymhall mentioned this issue Nov 1, 2024
Merged
corymhall added a commit that referenced this issue Nov 2, 2024
@corymhall
Add integration tests for ApiGateway (#195)
1236da2 
This adds the first integration tests for ApiGateway. This will get us
to full coverage on ApiGateway constructs

Added on top of #194 so review
that one first.

re #183
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Nov 4, 2024
corymhall added a commit that referenced this issue Nov 7, 2024
@corymhall
Handle SecretsManager dynamic references
e6552b8 
CloudFormation has a capability that allows you to dynamically resolve
secretsmanager values at deploy time.

This PR adds special handling for these values by mapping them to
the `getSecretVersion` function. I can think of two ways that these
values would end up being referenced in a CDK application

1. The user provides a string value for the secretId and the reference
   is a complete string.
2. The user provides a reference value for the secretId and the
   reference is a Fn::Join intrinsic

There may be other cases, but if there are I think they are not very
common and we can handle them if users create issues.

re #183, fixes #199
@corymhall corymhall mentioned this issue Nov 7, 2024
Merged
corymhall added a commit that referenced this issue Nov 7, 2024
@corymhall
Add integration tests for kms
4aa381e 
re #183
corymhall added a commit that referenced this issue Nov 7, 2024
@corymhall
Add integration tests for kms
37bc399 
re #183
@corymhall corymhall mentioned this issue Nov 7, 2024
Merged
corymhall added a commit that referenced this issue Nov 7, 2024
@corymhall
Add support for Route53 records
ffcb8ea 
This PR adds support for Route53 records (`AWS::Route53::RecordSet`)
which is not currently supported by CCAPI.

I've also added integration tests for the Route53 constructs.

re #183, closes #177
@corymhall corymhall mentioned this issue Nov 7, 2024
Merged
corymhall added a commit that referenced this issue Nov 7, 2024
@corymhall
Add additional ec2 integration tests
916d7e4 
This adds the remaining ec2 integration tests

re #183
@corymhall corymhall mentioned this issue Nov 7, 2024
Merged
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add integration tests for kms (#203)
485a6bb 
re #183
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add additional ec2 integration tests (#205)
8263027 
This adds the remaining ec2 integration tests

re #183
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add support for Route53 records (#204)
129e930 
This PR adds support for Route53 records (`AWS::Route53::RecordSet`)
which is not currently supported by CCAPI.

I've also added integration tests for the Route53 constructs.

re #183, closes #177
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add integration tests for logs construct library
d05f2ac 
re #183
@corymhall corymhall mentioned this issue Nov 8, 2024
Merged
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add integration tests for logs construct library (#207)
0dfa36d 
re #183
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add integration tests for CloudFront construct library
26a72d0 
re #183
@corymhall corymhall mentioned this issue Nov 8, 2024
Merged
corymhall added a commit that referenced this issue Nov 8, 2024
@corymhall
Add integration tests for CloudFront construct library
55a41c8 
re #183
corymhall added a commit that referenced this issue Nov 11, 2024
@corymhall
Add integration tests for remaining resources
61cf3d5 
This adds integration tests for the remaining construct libraries.

Also adds mapping for one missing CCAPI resource
(`AWS::Events::EventBusPolicy`)

re #183
@corymhall corymhall mentioned this issue Nov 11, 2024
Merged
corymhall added a commit that referenced this issue Nov 11, 2024
@corymhall
Handle SecretsManager dynamic references (#202)
bebda31 
CloudFormation has a capability that allows you to dynamically resolve
secretsmanager values at deploy time.

This PR adds special handling for these values by mapping them to the
`getSecretVersion` function. I can think of two ways that these values
would end up being referenced in a CDK application

1. The user provides a string value for the secretId and the reference
is a complete string.
2. The user provides a reference value for the secretId and the
reference is a Fn::Join intrinsic

There may be other cases, but if there are I think they are not very
common and we can handle them if users create issues.

re #183, fixes #199
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 11, 2024
corymhall added a commit that referenced this issue Nov 11, 2024
@corymhall
Add integration tests for CloudFront construct library
94d1d9a 
re #183
corymhall added a commit that referenced this issue Nov 11, 2024
@corymhall
Add integration tests for CloudFront construct library (#208)
6e89877 
re #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.112
Development

Successfully merging a pull request may close this issue.

Add integration tests for remaining resources pulumi/pulumi-cdk
6 participants
@t0yv0 @mjeffryes @mikhailshilkov @cleverguy25 @pulumi-bot @corymhall