Add integration tests for ApiGateway #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the setup necessary for integration tests. I'll follow this up with other PRs that add specific integration tests. Integration tests will be tests that add resource test coverage, but should not serve as "examples" for users.
This adds the first integration tests for ApiGateway. This will get us to full coverage on ApiGateway constructs re #183
t0yv0
reviewed
Nov 2, 2024
|
|
||
| func TestApiGatewayDomain(t *testing.T) { | ||
| // This can be run manually in the dev account | ||
| t.Skip("This test requires a valid public Route53 domain which doesn't exist in the CI account") |
There was a problem hiding this comment.
Remind me to double-check this. We had something like "demos.*" but maybe only in devsandbox account.
t0yv0
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first integration tests for ApiGateway. This will get us
to full coverage on ApiGateway constructs
Added on top of #194 so review that one first.
re #183