Add integration tests for CloudFront construct library #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corymhall
commented
Nov 8, 2024
| @@ -7,7 +7,7 @@ | |||
| "@pulumi/aws": "^6.0.0", | |||
| "@pulumi/aws-native": "^1.0.0", | |||
| "@pulumi/pulumi": "^3.0.0", | |||
| "aws-cdk-lib": "2.149.0", | |||
| "aws-cdk-lib": "2.156.0", | |||
There was a problem hiding this comment.
Updating the dev dependency for a new CloudFront feature.
corymhall
force-pushed
the
corymhall/integration-cloudfront
branch
from
26a72d0 to
55a41c8
Compare
t0yv0
reviewed
Nov 11, 2024
| func TestCloudFront(t *testing.T) { | ||
| test := getJSBaseOptions(t). | ||
| With(integration.ProgramTestOptions{ | ||
| Dir: filepath.Join(getCwd(t), "cloudfront"), |
There was a problem hiding this comment.
Would it be possible to add a quick assert, even if it's hello-world style, that some output of the stack got returned correctly? Thanks!
t0yv0
approved these changes
Nov 11, 2024
flostadler
approved these changes
Nov 11, 2024
corymhall
force-pushed
the
corymhall/integration-cloudfront
branch
from
db3bd00 to
fb94cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #183