-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog update #1377
Changelog update #1377
Conversation
5c61a9e
to
b6993a7
Compare
b6993a7
to
711363b
Compare
What happened here? Did you start a new branch against an old branch HEAD or something? Perhaps this should be rebased on master, I can't really make out what is going on in the diff ;-) |
There is a lot happening in this, I would really love a sanity check by you so I accidentally don't break anything. |
We're not going to force push to the master branch, at this point it has gone out to hundreds or thousands of systems using plugin managers that follow Git HEAD for updates. If you want to backfill the changelog just squash all this down to one commit under your own name. If you want to call out point releases and tag the backdated ones where the features are that's fine, but I wouldn't bother. I would just to one point release based on where |
I wanted to keep the tags pointing to the right commits with the included changelog. Thanks for pointing out the problem with this, I haven't thought about plugin managers and I'm not sure how they would handle it. |
Description of Changes
Closes #1376
New Version Info
Author's Instructions
MAJOR.MINOR.PATCH
version number. Increment the:MAJOR
version when you make incompatible API changesMINOR
version when you add functionality in a backwards-compatible mannerPATCH
version when you make backwards-compatible bug fixesCollaborator's Instructions