-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding change logs for few last merged PRs and create tags for them #1376
Comments
Personally I see the value in changelogs for some projects, but generally not my editor plugins. The plugin managers I use show me the Git shortlog any time I update plugins. I also have no objection to a changelog being maintained if somebody either wants to take ownership of it or sends contributions to it. If you want to backfill the changelog with the things that have been missed, go for it. |
@alerque I agree changelog itself doesn't do anything important especially when it's only a line of description for each release, but keeping a tag for every release can help when someone wants to rollback to a specific version. |
This is sort of true, but is really only meaningful if the tags are not on every commit! For a long time the flow in this repo has bee to tag basically every commit that landed on master. I don't think that's a very useful kind of tag, in that case why not just use the commit SHA? Tags are great as markers for specific states, but I would imagine releasing them a little more periodically will give people tracking HEAD a chance to get the latest while people that don't want any churn might stick to tags. More importantly I think the fact that more plugin managers are moving away from HEAD and towards using tags if they exist (looking at you My suggestion would be to ditch the changelog, still try to keep HEAD in a known-working state at all times, but only periodically add new tags for batches of changes without letting unreleased stuff sit around too long but giving it a little bit of a chance to shake out issues too. |
One way of doing it can be keeping the changelog as it is but only releasing a tag on each minor update instead of on every patch. This way we can honor the old format of the changelog file while making releases more impactful, containing stable changes in them. |
I've created a draft PR #1377 for this change, But first, let's make sure we would want to keep using it going forward. In case we want to keep using CHANGELOG.md I have a few suggestions.
Let me know whether you think it's a good approach or not, To be honest, I'm not really sure about it. |
I would like to add that I think changes to GitHub files for example ci shouldn't be mentioned in the change log. We should only keep it for the plugin changes. |
Yes, that is one advantage of a changelog over For projects that have a lot of commit action and relatively rare releases that becomes increasingly important. For such cases I typically prefer to setup an automatic changelog generated based on conventional commits using |
...and at this point you're the most active maintainer, so go for it. Maybe document what the workflow is going to be and update the PR template to match. |
Hello guys,
NERDTree used to get updates to the change log on every change But right now we forgot to do it for the last few merge requests. So I was wondering are we going to ditch this way of versioning? if that's the case and preservim wants to stop versioning the NERDTree changes we can close this issue.
But I think it is just an understandable mistake because of the transition and the change of maintainer. I think it would be nice if we could continue this way of versioning it is handy to have the ability to switch between different versions of NERDTree directly within the plugin manager.
So I've created this Issue to keep track of this problem. We can either retroactively add the commits with CHANGELOG.md edits or combine the last few commits as a single version increase. I prefer the former way as it is much cleaner.
The text was updated successfully, but these errors were encountered: