Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmedia Bidder Adapter MD : initial release #5788
Bitmedia Bidder Adapter MD : initial release #5788
Changes from 3 commits
4e33088
f2a5afa
60f7f5b
a8c0d15
e3bd034
0972943
8e2fbf9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't claim to support first party data unless there's a section below describing what specific types of FPD: site.ext.data, site.content.data, user.data, user.ext.data, imp.ext.data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use all fpd that automatically collected by prebid
we can change this field to false or describe at block all fpd`s what we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code is already merged, I imagine you're eager to get the docs merged. So I won't hold it up for this, but really you ought to give yourself the credit for supporting FPD. All you have to do is as a note that says "Bitmedia supports all first party data: site.ext.data, site.content.data, user.ext.data, user.data, and imp.ext.data." But you can do that in a separate PR if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answer
We will finally consider how to describe it and make a separate pull request