-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmedia Bidder Adapter MD : initial release #5788
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/bitmedia.md
Outdated
safeframes_ok: true | ||
deals_supported: false | ||
floors_supported: true | ||
fpd_supported: true // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't claim to support first party data unless there's a section below describing what specific types of FPD: site.ext.data, site.content.data, user.data, user.ext.data, imp.ext.data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use all fpd that automatically collected by prebid
we can change this field to false or describe at block all fpd`s what we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code is already merged, I imagine you're eager to get the docs merged. So I won't hold it up for this, but really you ought to give yourself the credit for supporting FPD. All you have to do is as a note that says "Bitmedia supports all first party data: site.ext.data, site.content.data, user.ext.data, user.data, and imp.ext.data." But you can do that in a separate PR if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answer
We will finally consider how to describe it and make a separate pull request
Changes at bitmedia.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix linting errors or give me permission to fix them...
fix eslint errors at bitmedia.md
Fixed |
🏷 Type of documentation
📋 Checklist