Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmedia Bidder Adapter MD : initial release #5788

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

BitmediaDevTeam
Copy link
Contributor

@BitmediaDevTeam BitmediaDevTeam commented Jan 2, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 8e2fbf9
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/678955e235128e0008673416
😎 Deploy Preview https://deploy-preview-5788--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dev-docs/bidders/bitmedia.md Outdated Show resolved Hide resolved
dev-docs/bidders/bitmedia.md Outdated Show resolved Hide resolved
dev-docs/bidders/bitmedia.md Show resolved Hide resolved
safeframes_ok: true
deals_supported: false
floors_supported: true
fpd_supported: true //
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't claim to support first party data unless there's a section below describing what specific types of FPD: site.ext.data, site.content.data, user.data, user.ext.data, imp.ext.data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use all fpd that automatically collected by prebid
we can change this field to false or describe at block all fpd`s what we use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the code is already merged, I imagine you're eager to get the docs merged. So I won't hold it up for this, but really you ought to give yourself the credit for supporting FPD. All you have to do is as a note that says "Bitmedia supports all first party data: site.ext.data, site.content.data, user.ext.data, user.data, and imp.ext.data." But you can do that in a separate PR if you'd like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answer
We will finally consider how to describe it and make a separate pull request

@BitmediaDevTeam BitmediaDevTeam requested a review from bretg January 16, 2025 17:09
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linting errors or give me permission to fix them...

@BitmediaDevTeam
Copy link
Contributor Author

Fixed

@BitmediaDevTeam BitmediaDevTeam requested a review from bretg January 16, 2025 18:55
@bretg bretg added LGTM and removed needs work labels Jan 16, 2025
@bretg bretg merged commit 94580d7 into prebid:master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants