updated billing for base and gnosis! #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wtfsayo
commented
May 20, 2024
wtfsayo
commented
- updated watcher for base, gnosis
- can't add gnosis to swap as its not supported by 0x
Closed
plor
approved these changes
May 20, 2024
| parseLogs(logs: any[], network: string): IParsedLog[] { | ||
| return logs.map((log: any) => ({ | ||
| tenantId: fromHex(log?.args?._identifier, 'string').replaceAll(`\x00`, ''), | ||
| amount: Number(log?.args?._amount), |
There was a problem hiding this comment.
This needs to be sized correctly. It is currently 18 decimals, will give the user too many credits (currently 1 trillion times too many).
| const blockNumber = await client.getBlockNumber(); | ||
| const logs = await client.getLogs({ | ||
| event, | ||
| address: portrAddress, |
There was a problem hiding this comment.
This isn't guaranteed to be the same on every network.
Comment on lines
+176
to
+178
| { client: opClient, name: 'optimism' }, | ||
| { client: gnosisClient, name: 'gnosis' }, | ||
| { client: baseClient, name: 'base' } |
There was a problem hiding this comment.
Is this manageable going forward. At what point do we have too many chains to support with the code this way?
plor
reviewed
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.