Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design review changes #262

Closed
wants to merge 7 commits into from
Closed

Design review changes #262

wants to merge 7 commits into from

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented May 20, 2024

follow up to #261

  • branch is based off the PR branch!

@wtfsayo wtfsayo requested a review from plor May 20, 2024 09:52
plor
plor suggested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate these changes from the other PR? Too many different things going on here.

@wtfsayo wtfsayo closed this May 21, 2024
@wtfsayo wtfsayo deleted the design-review-changes branch May 21, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtfsayo @plor