remove custom log message editing (closes #1545) #1550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at this a fair bit, and tried to figure out why the
LogRecord
object that previously had non-emptyargs
now has empty logs, and also how to have a unit test for this, but didn't manage to on both counts.On the other hand, I don't actually think this code was actually doing anything:
The odd "warnings.warn(" lines are merely printing the line in the source code where the warning is raised, but the code was not removing that entirely.