Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR] 0004 - Separate Transport and Application Keys #35

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions ADRs/0004-separate-consensus-and-p2p-keys.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Separate Consensus and P2P Private Keys

* Status: in review
* Deciders: Pocket Network Team
* Date: 2023-04-17

Technical Story: [Consolidate and Refactor Node Identity](https://github.com/pokt-network/pocket/issues/348)

## Context and Problem Statement

In the context of maintaining a secure and robust network, we need to decide whether to use separate private keys for P2P and consensus modules, or use a single private key for both purposes.
Combining the keys could simplify the identity management, but may also increase security risks and impact system quality.

## Decision Drivers

* Security: Minimizing the risks associated with key compromise
bryanchriswhite marked this conversation as resolved.
Show resolved Hide resolved
* Simplification: Reducing complexity in identity management
* Flexibility: Allowing different key management strategies for different modules
* Isolation: Minimizing the impact of compromise on other system components
bryanchriswhite marked this conversation as resolved.
Show resolved Hide resolved

## Considered Options

* Option 1: Use a single private key for both P2P and consensus modules
* Option 2: Use separate private keys for P2P and consensus modules

## Decision Outcome

Chosen option: "Option 2: Use separate private keys for P2P and consensus modules", because this approach provides a better security posture, enables greater flexibility in key management strategies, and isolates the impact of potential key compromises.
bryanchriswhite marked this conversation as resolved.
Show resolved Hide resolved

### Positive Consequences

* Improved security: Compromise of one private key does not directly impact the other module
* Flexibility: Different key management strategies can be applied to each module
* Isolation: Minimizes the impact of compromise on other system components

### Negative Consequences

* Increased complexity: Requires managing separate private keys for different module

## Pros and Cons of the Options

### Option 1: Use a single private key for both P2P and consensus modules

* Good, because it simplifies identity management
* Bad, because a compromise in one module directly impacts the other module
* Bad, because it limits the ability to apply different key management strategies to each module

### Option 2: Use separate private keys for P2P and consensus modules

* Good, because it improves security by isolating potential compromises
* Good, because it allows for greater flexibility in key management strategies
* Bad, because it increases complexity in managing separate private keys for different modules