generated from pokt-network/repo-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADR] 0004 - Separate Transport and Application Keys #35
Open
bryanchriswhite
wants to merge
5
commits into
main
Choose a base branch
from
docs/ADR0004
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7513550
docs: add ADR0004
bryanchriswhite 753cbe6
ADR0004: status "in review"
bryanchriswhite a41500e
Merge remote-tracking branch 'pokt/main' into docs/ADR0004
bryanchriswhite 383f43a
chore: incorporate updated template & review feedback
bryanchriswhite 92cab45
edit: adding detail
bryanchriswhite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
# Separate of Transport and Application Keys | ||
|
||
- Status: in review | ||
- Deciders: Pocket Network Protocol Team | ||
- Date: 2023-05-19 | ||
|
||
**Table of Contents** | ||
|
||
- [Summary](#summary) | ||
- [Problem Statement](#problem-statement) | ||
- [Background](#background--origin-document--technical-story-) | ||
- [Decision Drivers](#decision-drivers-) | ||
- [Considered Options](#considered-options-) | ||
- [Decision Outcome](#decision-outcome-) | ||
- [Positive Consequences](#positive-consequences-) | ||
- [Negative Consequences](#negative-consequences-) | ||
- [Pros and Cons of the Options](#pros-and-cons-of-the-options-) | ||
- [Option 1: Use a single private key for both P2P and other functionalities](#option-1) | ||
- [Option 2: Use separate private keys for P2P and other functionalities](#option-2) | ||
- [References](#references-) | ||
|
||
## Summary | ||
|
||
In the context of maintaining a secure and robust network, facing the concern of key compromise, we decided for Option 2, separating keys between P2P and other functionalities (consensus, utility etc.), and neglected Option 1, to achieve better security posture, flexibility, and isolation, accepting the increased complexity in identity management, because this approach provides a more holistic and secure solution for the network. | ||
|
||
## Problem Statement | ||
|
||
We need to decide whether to use separate private keys for P2P and other functionalities (like consensus and utility related logic), or use a single private key for all purposes. Combining the keys could simplify the identity management, but may also increase security risks and impact system quality. | ||
|
||
## Background | ||
|
||
[Consolidate and Refactor Node Identity](https://github.com/pokt-network/pocket/issues/348) | ||
|
||
## Decision Drivers | ||
|
||
- Security: Minimizing the risks associated with key compromise | ||
- Simplification: Reducing complexity in identity management and node configuration | ||
- **Flexibility/Modularity**: Allowing different key management strategies for different modules | ||
- Isolation: Minimizing the impact of compromise on other system components | ||
- Optionality: Enabling future changes and extensions to the protocol | ||
|
||
## Considered Options | ||
|
||
1. Use a single private key for both P2P and other functionalities (i.e. consensus, utility, etc...) | ||
2. Use separate private keys for P2P and other functionalities | ||
|
||
## Decision Outcome | ||
|
||
Chosen option: 2, because this approach provides a better security posture, enables greater flexibility in key management strategies, and isolates the impact of potential key compromises. | ||
|
||
### Positive Consequences | ||
|
||
- Improved security: Compromise of one private key does not directly impact the other functionalities | ||
- Flexibility: Different key management strategies can be applied to each functionality | ||
|
||
### Negative Consequences | ||
|
||
- Increased complexity: Requires managing separate private keys for different functionalities | ||
|
||
## Pros and Cons of the Options | ||
|
||
### Option 1: Use a single private key for both P2P and other functionalities | ||
|
||
Pros: | ||
|
||
- Simplifies identity management | ||
|
||
Cons: | ||
|
||
- A compromise in one functionality directly impacts the other functionalities | ||
- Limits the ability to apply different key management strategies to each functionality | ||
|
||
### Option 2: Use separate private keys for P2P and other functionalities | ||
|
||
Pros: | ||
|
||
- Improves security by isolating potential compromises | ||
- Allows for greater flexibility in key management strategies | ||
|
||
Cons: | ||
|
||
- Increases complexity in managing separate private keys for different functionalities | ||
|
||
## References | ||
|
||
- [Consolidate and Refactor Node Identity](https://github.com/pokt-network/pocket/issues/348) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no mention of things like: