Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruletest 23-1 update #1625

Merged
merged 10 commits into from
Jan 30, 2025
Merged

Ruletest 23-1 update #1625

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed4d02b
UPDATE 23-1 based on modification in #1434
weilixu Jan 17, 2025
2e67878
Updated ruletest 23-1 to correspond with latest RDS. Much simpler app…
Jan 25, 2025
db6909c
Merge branch 'develop' of https://github.com/pnnl/ruleset-checking-to…
weilixu Jan 30, 2025
0f91b70
Merge branch 'RT/JG/ruletest_23_1_update' of https://github.com/pnnl/…
weilixu Jan 30, 2025
5ff3cc6
clean up codes
weilixu Jan 30, 2025
4d6aca0
Small fixes on 23-1 ruletest for high temperature cutoffs on system 2…
Jan 30, 2025
5f97557
Merge branch 'RS/WX/update_23-1' into RT/JG/ruletest_23_1_update
Jan 30, 2025
5fd7131
Small correction to cause 40 F to fail for high temperature cutoff, n…
Jan 30, 2025
d0736e1
Undid false correction. 40 F and lower for aux shutoff is ok! Misread…
Jan 30, 2025
f84de0f
Minor correction on test description.
Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 11 additions & 185 deletions rct229/ruletest_engine/ruletest_jsons/ashrae9012019/section23/rule_23_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"Section": 23,
"Rule": 1,
"Test": "a",
"test_description": "The project has one building segment with one zone served by baseline system 2. with a heat pump low shut off of less than 17 F.",
"expected_rule_outcome": "pass",
"test_description": "The project has one building segment with one zone served by baseline system 2. The auxiliary heat high temperature shutoff is greater than 40 F.",
"expected_rule_outcome": "fail",
"standard": {
"rule_id": "23-1",
"ruleset_reference": "G3.1.3.1",
Expand All @@ -26,15 +26,12 @@
"buildings": [
{
"id": "Building 1",
"building_open_schedule": "Required Building Schedule 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1",
"thermostat_heating_setpoint_schedule": "Required Heating Schedule 1",
"terminals": [
{
"id": "PTHP Terminal 1",
Expand All @@ -55,7 +52,8 @@
"heating_system": {
"id": "HP Heating Coil 1",
"type": "HEAT_PUMP",
"heatpump_low_shutoff_temperature": -8.888888888888857
"heatpump_auxilliary_heat_type": "ELECTRIC_RESISTANCE",
"heatpump_low_shutoff_temperature": 7.222222222222285
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data should be heatpump_auxilliary_heat_high_shutoff_temperature, and the value is 40F

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh my mistake on the key value. And sure, I can lower it to 40 F. I wasn't sure if the energize auxiliary heat only when the outdoor air temperature is less than 40 F was inclusive so bumped it up to 45 F bit to make sure it'd flag a failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weilixu
According to the RDS, if at 40 F, the test should fail. However, the python code has an equals here.

I will add these updates to this PR and let you pull it in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually-- I'm starting to think I got this mixed up (this is why I never do tests right on the line, I get myself all confused). It looks like 40 F should pass. Sorry, let me make this update.

},
"fan_system": {
"id": "CAV Fan System 1",
Expand All @@ -82,7 +80,7 @@
"Section": 23,
"Rule": 1,
"Test": "b",
"test_description": "The project has one building segment with one zone served by baseline system 2 with a heat pump low shut off greater than 25 F. The expected result is: fail",
"test_description": "The project has one building segment with one zone served by baseline system 2. The auxiliary heat fuel type is not electric resistance.",
"expected_rule_outcome": "fail",
"standard": {
"rule_id": "23-1",
Expand All @@ -105,15 +103,12 @@
"buildings": [
{
"id": "Building 1",
"building_open_schedule": "Required Building Schedule 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1",
"thermostat_heating_setpoint_schedule": "Required Heating Schedule 1",
"terminals": [
{
"id": "PTHP Terminal 1",
Expand All @@ -134,7 +129,8 @@
"heating_system": {
"id": "HP Heating Coil 1",
"type": "HEAT_PUMP",
"heatpump_low_shutoff_temperature": -3.3333333333333144
"heatpump_auxilliary_heat_type": "OTHER",
"heatpump_low_shutoff_temperature": 1.6666666666666856
},
"fan_system": {
"id": "CAV Fan System 1",
Expand All @@ -161,8 +157,8 @@
"Section": 23,
"Rule": 1,
"Test": "c",
"test_description": "The project has one building segment with one zone served by baseline system 2 with a heat pump low shut off between 17 F and 25 F. The expected result is: undetermined",
"expected_rule_outcome": "undetermined",
"test_description": "The project has one building segment with one zone served by baseline system 2. The auxiliary heat fuel type is electric resistance and the high temperature shutoff for the auxiliary heat is less than 40 F.",
"expected_rule_outcome": "pass",
"standard": {
"rule_id": "23-1",
"ruleset_reference": "G3.1.3.1",
Expand All @@ -184,15 +180,12 @@
"buildings": [
{
"id": "Building 1",
"building_open_schedule": "Required Building Schedule 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1",
"thermostat_heating_setpoint_schedule": "Required Heating Schedule 1",
"terminals": [
{
"id": "PTHP Terminal 1",
Expand All @@ -213,86 +206,8 @@
"heating_system": {
"id": "HP Heating Coil 1",
"type": "HEAT_PUMP",
"heatpump_low_shutoff_temperature": -6.666666666666629
},
"fan_system": {
"id": "CAV Fan System 1",
"fan_control": "CONSTANT",
"supply_fans": [
{
"id": "Supply Fan 1"
}
]
}
}
]
}
]
}
],
"type": "BASELINE_0"
}
]
}
}
},
"rule-23-1-d": {
"Section": 23,
"Rule": 1,
"Test": "d",
"test_description": "The project has one building segment with one zone served by baseline System 4 with a heat pump low shut off temperature below 10 F. The expected result is: pass",
"expected_rule_outcome": "pass",
"standard": {
"rule_id": "23-1",
"ruleset_reference": "G3.1.3.1",
"rule_description": "For baseline systems 2 and 4, the electric air-source heat pumps shall be modeled with electric auxiliary heat and an outdoor air thermostat. The systems shall be controlled to energize auxiliary heat only when the outdoor air temperature is less than 40\u00b0F. The air-source heat pump shall be modeled to continue to operate while auxiliary heat is energized.",
"applicable_rmr": "Baseline Model",
"rule_assertion": "=",
"comparison_value": "Expected Value",
"rule_dependency": "none",
"mandatory_rule": "Applicability",
"schema_version": "0.0.37"
},
"rmd_transformations": {
"baseline": {
"id": "ASHRAE229 1",
"data_timestamp": "2024-02-12T09:00Z",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_open_schedule": "Required Building Schedule 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1",
"thermostat_heating_setpoint_schedule": "Required Heating Schedule 1",
"terminals": [
{
"id": "Air Terminal",
"is_supply_ducted": true,
"type": "CONSTANT_AIR_VOLUME",
"served_by_heating_ventilating_air_conditioning_system": "System Type 4"
}
]
}
],
"heating_ventilating_air_conditioning_systems": [
{
"id": "System Type 4",
"cooling_system": {
"id": "DX Coil 1",
"type": "DIRECT_EXPANSION"
},
"heating_system": {
"id": "HP Coil 1",
"type": "HEAT_PUMP",
"heatpump_low_shutoff_temperature": -12.777777777777715
"heatpump_auxilliary_heat_type": "ELECTRIC_RESISTANCE",
"heatpump_low_shutoff_temperature": 1.6666666666666856
},
"fan_system": {
"id": "CAV Fan System 1",
Expand All @@ -301,95 +216,6 @@
{
"id": "Supply Fan 1"
}
],
"return_fans": [
{
"id": "Return Fan 1"
}
]
}
}
]
}
]
}
],
"type": "BASELINE_0"
}
]
}
}
},
"rule-23-1-e": {
"Section": 23,
"Rule": 1,
"Test": "e",
"test_description": "The project has one building segment with one zone served by baseline System 4 with a heat pump low shut off temperature above 10 F. The expected result is: fail",
"expected_rule_outcome": "fail",
"standard": {
"rule_id": "23-1",
"ruleset_reference": "G3.1.3.1",
"rule_description": "For baseline systems 2 and 4, the electric air-source heat pumps shall be modeled with electric auxiliary heat and an outdoor air thermostat. The systems shall be controlled to energize auxiliary heat only when the outdoor air temperature is less than 40\u00b0F. The air-source heat pump shall be modeled to continue to operate while auxiliary heat is energized.",
"applicable_rmr": "Baseline Model",
"rule_assertion": "=",
"comparison_value": "Expected Value",
"rule_dependency": "none",
"mandatory_rule": "Applicability",
"schema_version": "0.0.37"
},
"rmd_transformations": {
"baseline": {
"id": "ASHRAE229 1",
"data_timestamp": "2024-02-12T09:00Z",
"ruleset_model_descriptions": [
{
"id": "RMD 1",
"buildings": [
{
"id": "Building 1",
"building_open_schedule": "Required Building Schedule 1",
"building_segments": [
{
"id": "Building Segment 1",
"zones": [
{
"id": "Thermal Zone 1",
"thermostat_cooling_setpoint_schedule": "Required Cooling Schedule 1",
"thermostat_heating_setpoint_schedule": "Required Heating Schedule 1",
"terminals": [
{
"id": "Air Terminal",
"is_supply_ducted": true,
"type": "CONSTANT_AIR_VOLUME",
"served_by_heating_ventilating_air_conditioning_system": "System Type 4"
}
]
}
],
"heating_ventilating_air_conditioning_systems": [
{
"id": "System Type 4",
"cooling_system": {
"id": "DX Coil 1",
"type": "DIRECT_EXPANSION"
},
"heating_system": {
"id": "HP Coil 1",
"type": "HEAT_PUMP",
"heatpump_low_shutoff_temperature": -9.4444444444444
},
"fan_system": {
"id": "CAV Fan System 1",
"fan_control": "CONSTANT",
"supply_fans": [
{
"id": "Supply Fan 1"
}
],
"return_fans": [
{
"id": "Return Fan 1"
}
]
}
}
Expand Down
Loading