Ruletest 23-1 update #1625
Merged
Ruletest 23-1 update #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into RS/WX/update_23-1
…ruleset-checking-tool into RS/WX/update_23-1
weilixu
requested changes
Jan 30, 2025
| @@ -55,7 +52,8 @@ | |||
| "heating_system": { | |||
| "id": "HP Heating Coil 1", | |||
| "type": "HEAT_PUMP", | |||
| "heatpump_low_shutoff_temperature": -8.888888888888857 | |||
| "heatpump_auxilliary_heat_type": "ELECTRIC_RESISTANCE", | |||
| "heatpump_low_shutoff_temperature": 7.222222222222285 | |||
There was a problem hiding this comment.
This data should be heatpump_auxilliary_heat_high_shutoff_temperature, and the value is 40F
There was a problem hiding this comment.
ahh my mistake on the key value. And sure, I can lower it to 40 F. I wasn't sure if the energize auxiliary heat only when the outdoor air temperature is less than 40 F was inclusive so bumped it up to 45 F bit to make sure it'd flag a failure.
There was a problem hiding this comment.
Actually-- I'm starting to think I got this mixed up (this is why I never do tests right on the line, I get myself all confused). It looks like 40 F should pass. Sorry, let me make this update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rule 23-1's rule test JSON to align with the latest RDS changes