Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ecto_ch and use ecto hints for array joins #4456

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Aug 21, 2024

Changes

This PR updates ecto_ch to a more recent version that allows using hints for array joins and updates Plausible to use that. This makes further updates to Ecto (3.11 -> 3.12) and ecto_ch (0.3.8 -> 0.3.9) easier since in the latest version (0.3.9) ecto_ch drops support for :array_join and starts depending on Ecto 3.12 due to some internal changes to parameterized types.

Tests

  • Automated tests have been updated

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga marked this pull request as ready for review August 21, 2024 04:20
@ruslandoga ruslandoga requested a review from aerosol August 21, 2024 04:20
Copy link
Member

@aerosol aerosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's gooo!

@aerosol aerosol merged commit 48dfce7 into master Aug 21, 2024
10 checks passed
@aerosol aerosol deleted the update-ecto-ch branch August 21, 2024 04:28
@ruslandoga ruslandoga mentioned this pull request Aug 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants