Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch shell / connect to use caching_sha2_password by default #919

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

dbussink
Copy link
Collaborator

@dbussink dbussink commented Oct 9, 2024

This switches up both connect and shell to use caching_sha2_password by default. connect gets an option to also select the legacy mysql_native_password option. shell selects based on the mysql --version returns. For MySQL 8.x and later, it now uses caching_sha2_password.

Alternative to #918

Depends on planetscale/psdbproxy#24

@dbussink dbussink requested a review from a team as a code owner October 9, 2024 12:07
@dbussink dbussink force-pushed the dbussink/use-caching-sha2-password branch from ad4851a to 5533341 Compare October 9, 2024 12:10
@dbussink dbussink marked this pull request as draft October 9, 2024 14:39
@dbussink dbussink marked this pull request as ready for review October 9, 2024 14:39
This switches up both connect and shell to use `caching_sha2_password`
by default. `connect` gets an option to also select the legacy
`mysql_native_password` option. `shell` selects based on the `mysql
--version` returns. For MySQL 8.x and later, it now uses
`caching_sha2_password`.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/use-caching-sha2-password branch from 5533341 to d68bc44 Compare October 9, 2024 14:54
@dbussink
Copy link
Collaborator Author

dbussink commented Oct 9, 2024

Fixes #916

@dbussink dbussink merged commit 502e3aa into main Oct 9, 2024
1 check passed
@dbussink dbussink deleted the dbussink/use-caching-sha2-password branch October 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants