Fix the MySQL version detection and only use up to MySQL 8.x #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL 9.x is backwards compatibility breaking as it removes support for `mysql_native_password` which is what is used with PlanetScale as the default at the moment. So enforce MySQL 8.x as the latest at the moment. Also upgrade planetscale-go and add some empty test mocks for now so it can compile. This update removes a bunch of legacy code so it can't be used accidentally either. Signed-off-by: Dirkjan Bussink <[email protected]>
|
Fixes #916 |
|
I had planetscale/psdbproxy#24 as an alternative idea here that's more future proof but breaks some really old clients with the CLI / proxy. |
iheanyi
approved these changes
Oct 9, 2024
|
Closing in favor of #919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 9.x is backwards compatibility breaking as it removes support for
mysql_native_passwordwhich is what is used with PlanetScale as the default at the moment.So enforce MySQL 8.x as the latest at the moment.
Also upgrade
planetscale-goand add some empty test mocks for now so it can compile. This update removes a bunch of legacy code so it can't be used accidentally either.