Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33786) feat(accessibility): Add 2025 acccessibility action plan #7505

Merged
merged 6 commits into from
Jan 10, 2025
Merged

(PC-33786) feat(accessibility): Add 2025 acccessibility action plan #7505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b9dfbf
(PC-33786) feat(accessibility): add noMawWidth in SecondaryPageWithBl…
lbeneston-pass Jan 10, 2025
0d637b3
(PC-33786) feat(accessibility): update 2024 accessibility action plan
lbeneston-pass Jan 10, 2025
74dfc5a
(PC-33786) feat(accessibility): add status details in ActionPlanTag
lbeneston-pass Jan 10, 2025
a2e8f42
(PC-33786) feat(accessibility): add 2025 accessibility action plan
lbeneston-pass Jan 10, 2025
d317fb8
(PC-33786) feat(accessibility): use userEvent instead fireEvent in ac…
lbeneston-pass Jan 10, 2025
6d0d12c
(PC-33786) feat(v2): change noMaxWidth > enableMaxWidth
lbeneston-pass Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions __snapshots__/features/achievements/pages/Achievements.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ exports[`<Achievements/> should match snapshot 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions ...h/pages/forgottenPassword/ForgottenPassword/ForgottenPassword.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ exports[`<ForgottenPassword /> should match snapshot 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions ...s/forgottenPassword/ReinitializePassword/ReinitializePassword.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ exports[`ReinitializePassword Page should match snapshot 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions ...rgottenPassword/ResetPasswordEmailSent/ResetPasswordEmailSent.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ exports[`<ResetPasswordEmailSent /> should match snapshot 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions __snapshots__/features/auth/pages/login/Login.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ exports[`<Login/> should render correctly when feature flag is enabled 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions ...p/SignupConfirmationEmailSent/SignupConfirmationEmailSentPage.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ exports[`<SignupConfirmationEmailSentPage /> should render correctly 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
1 change: 1 addition & 0 deletions __snapshots__/features/favorites/pages/FavoritesSorts.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ exports[`<FavoritesSorts/> should render correctly 1`] = `
"width": "100%",
}
}
enableMaxWidth={true}
scrollEnabled={true}
style={
[
Expand Down
3 changes: 2 additions & 1 deletion __snapshots__/features/profile/pages/Accessibility/Accessibility.native.test.tsx.native-snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,13 @@ exports[`Accessibility should render correctly 1`] = `
contentContainerStyle={
{
"alignSelf": "center",
"maxWidth": 500,
"maxWidth": "100%",
"paddingHorizontal": 24,
"paddingVertical": 24,
"width": "100%",
}
}
enableMaxWidth={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me demandais si le nom était explicite, et je suis allé voir tout en bas le code associé.
Je pense qu'en lisant enableThemeMaxWith j'aurai mieux compris le lien entre maxWidth:"100%" et enableMaxWidth={false}` :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que c'est pas si important, à terme il faudra supprimer le theme.contentPage.maxWidth (et donc cette props) qui créé des pages très peu large en web alors que c'est inutile :'D

scrollEnabled={true}
style={
[
Expand Down
Loading
Loading