(PC-33786) feat(accessibility): Add 2025 acccessibility action plan #7505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbeneston-pass
force-pushed
the
PC-33786
branch
from
99d667c to
ecd109f
Compare
lbeneston-pass
force-pushed
the
PC-33786
branch
from
ecd109f to
a2e8f42
Compare
…cessibility tests
cgerrard-pass
approved these changes
Jan 10, 2025
|
|
| "paddingHorizontal": 24, | ||
| "paddingVertical": 24, | ||
| "width": "100%", | ||
| } | ||
| } | ||
| enableMaxWidth={false} |
There was a problem hiding this comment.
Je me demandais si le nom était explicite, et je suis allé voir tout en bas le code associé.
Je pense qu'en lisant enableThemeMaxWith j'aurai mieux compris le lien entre maxWidth:"100%" et enableMaxWidth={false}` :)
There was a problem hiding this comment.
Je pense que c'est pas si important, à terme il faudra supprimer le theme.contentPage.maxWidth (et donc cette props) qui créé des pages très peu large en web alors que c'est inutile :'D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33786
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change