feat: abstract RPC error over HaltReason
#14104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
rakita and
gakonst
as code owners
klkvr
force-pushed
the
klkvr/generic-halt-reason
branch
from
be187a5 to
5c5521f
Compare
mattsse
requested changes
Jan 30, 2025
Comment on lines
+330
to
+332
| ExecutionResult::Revert { .. } | ExecutionResult::Halt { .. } => { | ||
| // We know that transaction succeeded with a higher gas limit before, so any failure | ||
| // means that we need to increase it. |
There was a problem hiding this comment.
hmm, this now exempts all haltreasons, I am not sure if this is okay.
judging from the docs it might because we don't expect those.
so this seems fine,
I'd like to keep the docs+context here
mattsse
added
A-execution
mattsse
requested changes
Jan 30, 2025
Comment on lines
-340
to
-354
| // Both `OutOfGas` and `InvalidEFOpcode` can occur dynamically if the gas | ||
| // left is too low. Treat this as an out of gas | ||
| // condition, knowing that the call succeeds with a | ||
| // higher gas limit. | ||
| // | ||
| // Common usage of invalid opcode in OpenZeppelin: | ||
| // <https://github.com/OpenZeppelin/openzeppelin-contracts/blob/94697be8a3f0dfcd95dfb13ffbd39b5973f5c65d/contracts/metatx/ERC2771Forwarder.sol#L360-L367> | ||
|
|
||
| // Increase the lowest gas limit. | ||
| *lowest_gas_limit = tx_gas_limit; | ||
| } | ||
| err => { | ||
| // These cases should be unreachable because we know the transaction | ||
| // succeeds, but if they occur, treat them as an | ||
| // error. |
There was a problem hiding this comment.
can we keep these docs, why we don't return an error on halt here?
mattsse
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
HaltReasonAT for EVM traits andFromEvmHalttrait which is required to be implemented by RPC implementation error.For now the default halt reason is used everywhere because current revm does not yet have
ResultAndStategeneric over it, but it should be easy to plug into existing traits once we migrate to new revm.