Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: do not operate on HaltReason manually #14073

Closed
wants to merge 1 commit into from
Closed

refactor: do not operate on HaltReason manually #14073

wants to merge 1 commit into from

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Jan 29, 2025

Most of the time HaltReason can be treated as unknown internal EVM error. This PR removes usage of this type from RPC code

@klkvr klkvr requested review from mattsse and Rjected as code owners January 29, 2025 15:17
mattsse
mattsse reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this now removes useful context from the halt error because we no longer map it.
and we lose the oog error

@klkvr
Copy link
Collaborator Author

klkvr commented Jan 30, 2025

Superseded by #14104

@klkvr klkvr closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse