Auto Generated Indexes v2 #1472
+385
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,14 @@ on: | |
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.PANTHER_BOT_AUTOMATION_TOKEN }} | ||
| steps: | ||
|
|
@@ -32,6 +32,17 @@ jobs: | |
| uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b #v5.3.0 | ||
| with: | ||
| python-version: "3.11" | ||
| - name: Install dependencies | ||
| run: pip3 install -r ./.scripts/requirements.txt | ||
| - name: Generate indexes | ||
| run: python3 ./.scripts/generate_indexes.py | ||
| - name: Commit Indexes | ||
| run: | | ||
| git config user.email "[email protected]" | ||
|
There was a problem hiding this comment. @c0nfleis @canagno123 is this the right email to use for the bot? There was a problem hiding this comment. Let's use the |
||
| git config user.name "Panther Bot" | ||
| git add ./indexes | ||
| git commit -m "Update indexes" | ||
| git push --no-sign | ||
| - name: Create new panther-analysis release | ||
| run: | | ||
| export AWS_REGION=${{ secrets.AWS_REGION }} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbellifa after discussing with the team I think it would be better to run this in a separate GHA that runs on PRs to
developvs adding it to the release workflow. This will ensure develop stays in sync with main and let us test it more thoroughly prior to each release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielkr256 Would a workflow that triggered on a push to develop work? I'm thinking of using a filter that only runs when .yml files are changed so it doesn't loop. My concern with PRs is I'm reading that they can have different behavior/permission issues when a PR is opened from a fork, and I can envision increased merge conflicts if the indexes are built within the PRs themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think that sounds great!