-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Generated Indexes v2 #1472
base: develop
Are you sure you want to change the base?
Conversation
run: python3 ./.scripts/generate_indexes.py | ||
- name: Commit Indexes | ||
run: | | ||
git config user.email "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0nfleis @canagno123 is this the right email to use for the bot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the panther-bot-automation
, like so:
git config --global user.email "[email protected]"
git config --global user.name "panther-bot-automation"
@mbellifa this is awesome! Would it make sense to also include the rule descriptions in the indexes? |
@arielkr256 Good point, I updated the PR to add descriptions. You can see what it looks like in my little test fork: https://github.com/mbellifa/panther-analysis-test/blob/auto-indexes-run-fix/indexes/alpha-index.md |
@@ -4,14 +4,14 @@ on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbellifa after discussing with the team I think it would be better to run this in a separate GHA that runs on PRs to develop
vs adding it to the release workflow. This will ensure develop stays in sync with main and let us test it more thoroughly prior to each release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielkr256 Would a workflow that triggered on a push to develop work? I'm thinking of using a filter that only runs when .yml files are changed so it doesn't loop. My concern with PRs is I'm reading that they can have different behavior/permission issues when a PR is opened from a fork, and I can envision increased merge conflicts if the indexes are built within the PRs themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think that sounds great!
This is a non fork version of #1465, description copied below:
Background
Previously we generated the data for the Detection Coverage page manually. These changes aim to automate this generation as well as the markdown indexes in the
/indexes/
folder.Changes
detection-coverage.json
and markdown indexes when a release is cut, which is then written back to the repo.Testing