-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some changes needed for android compilation #5 #6
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/.idea/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,5 +54,9 @@ extern int white_moves[60]; | |
but all updates must be reversed when the search stops. */ | ||
extern Board board; | ||
|
||
#ifdef ANDROID | ||
int droidzebra_message_debug(const char* format, ...); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not the nicest thing in the world but what can we do 🤷♂️ Ideally this project should not depend on droidzebra like this, so the function should be somehow injected from the outside, but we got no time for that business There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe this could just be a standard debug function like message_debug ... |
||
#define printf(format, args...) droidzebra_message_debug(format , ## args) | ||
#endif | ||
|
||
#endif /* GLOBALS_H */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,8 @@ | |
#ifndef PORTING_H | ||
#define PORTING_H | ||
|
||
|
||
#ifdef ANDROID | ||
extern char android_files_dir[]; | ||
#endif | ||
|
||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep this, It's used in snapshot tests and fuzzer. Did you have problems with
getenv
on android?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think so. cant remember why i removed this, possible in a diff or something