Some changes needed for android compilation #5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panstromek
reviewed
Jul 1, 2023
| #elif defined( __linux__ ) | ||
| /* Linux don't support current directory. */ | ||
| strcpy( sPatternFile, PATTERN_FILE ); | ||
| #else | ||
| getcwd(sPatternFile, sizeof(sPatternFile)); | ||
| strcat(sPatternFile, "/" PATTERN_FILE); | ||
| #endif | ||
| char* env_coeffs = getenv("COEFFS_PATH"); |
There was a problem hiding this comment.
I'd like to keep this, It's used in snapshot tests and fuzzer. Did you have problems with getenv on android?
There was a problem hiding this comment.
i don't think so. cant remember why i removed this, possible in a diff or something
| @@ -54,5 +54,9 @@ extern int white_moves[60]; | |||
| but all updates must be reversed when the search stops. */ | |||
| extern Board board; | |||
|
|
|||
| #ifdef ANDROID | |||
| int droidzebra_message_debug(const char* format, ...); | |||
There was a problem hiding this comment.
not the nicest thing in the world but what can we do 🤷♂️
Ideally this project should not depend on droidzebra like this, so the function should be somehow injected from the outside, but we got no time for that business
There was a problem hiding this comment.
maybe this could just be a standard debug function like message_debug ...
panstromek
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made by #5 as a PR.