Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (data-table) hide change columns for non-numerical data #3094

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 11, 2024

  • relates to Data table: "Relative change" column doesn't make sense for some charts #2787
  • hides change columns for non-numerical data
  • note that Grapher currently doesn't have data type and models all table columns as NumberOrStringColumn, i.e these changes don't have any effect on grapher charts!
  • however, this change will have an effect on charts in explorers as explorers use columns of different data types
  • once we have data types in grapher (which we want to do), this will be useful for grapher as well

@sophiamersmann
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@sophiamersmann sophiamersmann changed the title ✨ (data-table) hide change columns for non-numerical columns ✨ (data-table) hide change columns for non-numerical data Jan 11, 2024
@sophiamersmann
Copy link
Member Author

Doesn't really make sense to merge this now since most Graphers don't have type information. One Grapher knows of data types, this makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant