Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (data-table) allow to hide change columns #3093

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 11, 2024

Background

  • Our config defines a tableDisplay field on the display property of a dimension
  • tableDisplay holds two properties, hideAbsoluteChange and hideRelativeChange, that hide change columns in the data table if set to true
  • But these fields are currently ignored by Grapher (I don't know why)
  • Both fields can be edited via the admin, but the UI is currently only exposed if tableDisplay already exists in the config

Summary

  • This PR makes it so that hideAbsoluteChange and hideRelativeChange are respected
  • Toggles to edit both fields are always exposed in the admin

Migration

  • 4 indicators set one of the fields to true (Datasette)
  • A single chart currently sets one of the fields to true (Datasette)

Screenshots

Admin

Screenshot 2024-01-11 at 17 53 48

@sophiamersmann
Copy link
Member Author

@sophiamersmann sophiamersmann merged commit 1237a59 into master Jan 16, 2024
23 checks passed
@sophiamersmann sophiamersmann deleted the admin-table-display branch January 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data table: "Relative change" column doesn't make sense for some charts
1 participant