Allow ZAC extensions to define additional items for the "More Actions" drop down #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rgallettonf
commented
Apr 25, 2024
rgallettonf
commented
- refactored header component "requestActions()" functions to emit generic actions to support extension service actions
- added No-Op functions for forms that don't require additional "More Actions" items
…" drop down * refactored header component "requestActions()" functions to emit generic actions to support extension service actions * added No-Op functions for forms that don't require additional "More Actions" items
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
would it be possible to make a sample and document how this kind of extension would work? maybe point to some angular doc/links that cover it, that sorta thing? |
dovholuknf
reviewed
Apr 25, 2024
| @@ -28,6 +28,7 @@ | |||
| (dataChange)="dataChanged($event)" | |||
| > | |||
| <ng-content select="[slot=provider]" slot="provider"></ng-content> | |||
| <ng-content select="[slot=registration]" slot="registration"></ng-content> | |||
There was a problem hiding this comment.
we spoke live about making these sorts of things more generic and thinking about pages as "layouts" not as "openziti" vs "specific" extensions. for example, "registration" slot is very specific. it'd be better, imo, as somethinglike "column 2, slot 1" or something like that...
dovholuknf
approved these changes
Apr 25, 2024
|
Updated PR with extension service example & README.md Updated edge router extension/project slots to use more generic naming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.