Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Query Time if "Plan Trip" clicked #1338

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:
Previously, the updateQueryTimeIfLeavingNow function was being called incorrectly in a way that wasn't connected to redux. This ensures the time is updated on every "plan trip" click.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Part of me wants to see this moved to the plan request submission logic to avoid having to drill it everywhere but things seem to work so good enough for now!

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amy-corson-ibigroup amy-corson-ibigroup merged commit ed88289 into dev Jan 23, 2025
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the fix-update-leave-now branch January 23, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants