Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small language string issues #1342

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Fix small language string issues #1342

merged 6 commits into from
Jan 27, 2025

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Jan 22, 2025 •
edited
Loading

Description:

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@amy-corson-ibigroup amy-corson-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Jan 22, 2025
@amy-corson-ibigroup amy-corson-ibigroup self-assigned this Jan 22, 2025
@amy-corson-ibigroup amy-corson-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Jan 23, 2025
@amy-corson-ibigroup amy-corson-ibigroup removed their assignment Jan 23, 2025
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches thanks!

@amy-corson-ibigroup
Copy link
Contributor Author

I piggybacked a small bugfix for #1338 in 94259e4.

In #1338 we update the query time AFTER we make the routing request, this is just putting things in the correct order.

josh-willis-arcadis
josh-willis-arcadis approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amy-corson-ibigroup amy-corson-ibigroup merged commit 44d769e into dev Jan 27, 2025
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the fix-translation-errors branch January 27, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @miles-grant-ibigroup @josh-willis-arcadis