Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toast for companion updates #1331

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Fix toast for companion updates #1331

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72798ee
fix(AddEmailForm): Set form name to its id and add field name for toast.
binh-dam-ibigroup Dec 20, 2024
d8142f7
Merge branch 'dev' into remove-companion-update-toast
binh-dam-ibigroup Dec 20, 2024
2f33065
chore(i18n): Add exception for companion field name
binh-dam-ibigroup Dec 20, 2024
4b74571
Merge branch 'dev' into remove-companion-update-toast
binh-dam-ibigroup Jan 6, 2025
bca731f
chore(i18n): Use "Trusted Companions" in toast header.
binh-dam-ibigroup Jan 6, 2025
e1eba1f
chore(i18n): Use "Travel Companions" in toast header
binh-dam-ibigroup Jan 6, 2025
adb88a9
Merge branch 'dev' into remove-companion-update-toast
binh-dam-ibigroup Jan 6, 2025
87ab384
Merge branch 'dev' into remove-companion-update-toast
binh-dam-ibigroup Jan 9, 2025
d9a00f4
improvement: Add title to toasts on mobility wiz, saved trip.
binh-dam-ibigroup Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions i18n/en-US.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,7 @@ components:
errorUpdatingProfile: Error updating profile.
fieldUpdated: This setting has been updated.
fields:
add-companion-form: Companions
binh-dam-ibigroup marked this conversation as resolved.
Show resolved Hide resolved
storeTripHistory: Store trip history
updating: Updating
UserSettings:
Expand Down
1 change: 1 addition & 0 deletions i18n/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@ components:
errorUpdatingProfile: Erreur dans la mise à jour de votre profil.
fieldUpdated: Ce paramètre a été mis à jour.
fields:
add-companion-form: Accompagnateurs
storeTripHistory: Enregistrement des recherches
updating: Mise à jour
UserSettings:
Expand Down
1 change: 1 addition & 0 deletions i18n/i18n-exceptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"push"
],
"components.UserAccountScreen.fields.*": [
"add-companion-form",
"storeTripHistory"
],
"components.OTP2ErrorRenderer.*.body": [
Expand Down
4 changes: 2 additions & 2 deletions lib/components/user/common/add-email-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Field, Form, Formik } from 'formik'
import React, { ReactNode } from 'react'
import styled from 'styled-components'

import { ControlStrip, phoneFieldStyle } from '../styled'
import { phoneFieldStyle } from '../styled'
import SubmitButton from '../../util/submit-button'

interface Props {
Expand Down Expand Up @@ -64,7 +64,7 @@ const AddEmailForm = ({
<FormGroup validationState={showError ? 'error' : null}>
<ControlLabel>{label}</ControlLabel>
<Controls>
<Form id={id} noValidate />
<Form id={id} name={id} noValidate />
<Field
aria-invalid={showError}
aria-required
Expand Down
Loading