Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toast for companion updates #1331

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Dec 20, 2024

Description

Fix #1330

Also adds titles to toasts for saved trips, mobility wizard.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?
Before After
before screenshot image

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toast is working. I think the text should be changed to match the section header. Also I noticed when updating a users mobility profile the toast does not include a header.
image

i18n/en-US.yml Outdated Show resolved Hide resolved
@binh-dam-ibigroup
Copy link
Collaborator Author

Also I noticed when updating a users mobility profile the toast does not include a header

Do you think there should be a header there too? "Settings" and "Mobility Profile" for their respective sections?

@josh-willis-arcadis
Copy link
Contributor

Also I noticed when updating a users mobility profile the toast does not include a header

Do you think there should be a header there too? "Settings" and "Mobility Profile" for their respective sections?

I think so. Every other section has a header in the toast except for this section.

@binh-dam-ibigroup
Copy link
Collaborator Author

Also I noticed when updating a users mobility profile the toast does not include a header

Do you think there should be a header there too? "Settings" and "Mobility Profile" for their respective sections?

I think so. Every other section has a header in the toast except for this section.

Updated in d9a00f4.

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for the changes. Looks great!

@josh-willis-arcadis josh-willis-arcadis removed their assignment Jan 9, 2025
@binh-dam-ibigroup binh-dam-ibigroup merged commit 64780b6 into dev Jan 9, 2025
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the remove-companion-update-toast branch January 9, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrambled field name shown for companion update toast
3 participants