Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Query-Insights-Dashboards-style-integration-QueryDetails #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KishoreKicha14
Copy link

Screenshot 2025-01-23 at 11 35 58 PM # QueryDetails Page UI Refinements

Description

This update introduces UI refinements to the QueryDetails page, focusing on improving consistency, accessibility, and overall layout. Key changes include:

  • Adjusted title sizes to match semantic HTML and accessibility standards.
  • Updated button sizes to size="s" to align with the global design system.
  • Compressed input fields for a cleaner and more compact UI.
  • Fine-tuned spacing between UI elements (e.g., horizontal rules, panels) for better readability.

UI Adjustments

  • Title Size: Updated to use semantic HTML tags and proper header sizes.
  • Button Size: Ensured buttons are consistently using size="s" for a streamlined appearance.
  • Input Fields: Compressed input fields where appropriate for a cleaner design.
  • Spacing: Fine-tuned spacing and margins around elements like horizontal rules and panels.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@deshsidd
Copy link
Collaborator

deshsidd commented Jan 27, 2025

Please run cypress tests, linting and unit tests locally before submitting PR if possible. @KishoreKicha14

Cypress tests can be run using:

run backend with ./gradlew run
run frontend with yarn start --server.host="0.0.0.0"
run cypress with yarn cypress run

Applicable for all 3 PRs

@KishoreKicha14 KishoreKicha14 force-pushed the Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails branch from d8f62cf to 1e8e0ce Compare January 31, 2025 08:15
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
@KishoreKicha14 KishoreKicha14 force-pushed the Fix-Query-Insights-Dashboards-Trineo-style-integration-QueryDetails branch from 1e8e0ce to c06fc4f Compare January 31, 2025 23:27
@KishoreKicha14 KishoreKicha14 changed the title Fix:Query-Insights-Dashboards-Trineo-style-integration-QueryDetails Fix:Query-Insights-Dashboards-style-integration-QueryDetails Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants