Skip to content

Commit

Permalink
Fix:Query-Insights-Dashboards-Trineo-style-integration-QueryDetails
Browse files Browse the repository at this point in the history
Signed-off-by: Kishore Kumaar Natarajan <[email protected]>
  • Loading branch information
Kishore Kumaar Natarajan committed Jan 24, 2025
1 parent 3577141 commit d8f62cf
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 17 deletions.
27 changes: 17 additions & 10 deletions public/pages/QueryDetails/Components/QuerySummary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,15 @@
*/

import React from 'react';
import { EuiFlexGrid, EuiFlexItem, EuiHorizontalRule, EuiPanel, EuiText } from '@elastic/eui';
import {
EuiFlexGrid,
EuiFlexItem,
EuiHorizontalRule,
EuiPanel,
EuiText,
EuiFormRow,
EuiTitle,
} from '@elastic/eui';
import { SearchQueryRecord } from '../../../../types/types';
import {
CPU_TIME,
Expand All @@ -21,21 +29,20 @@ import { calculateMetric } from '../../Utils/MetricUtils';
// Panel component for displaying query detail values
const PanelItem = ({ label, value }: { label: string; value: string | number }) => (
<EuiFlexItem>
<EuiText size="xs">
<h4>{label}</h4>
</EuiText>
<EuiText size="xs">{value}</EuiText>
<EuiFormRow label={label} compressed={true}>
<EuiText size="s">{value}</EuiText>
</EuiFormRow>
</EuiFlexItem>
);

const QuerySummary = ({ query }: { query: SearchQueryRecord | null }) => {
// If query is null, return a message indicating no data is available
if (!query) {
return (
<EuiPanel data-test-subj={'query-details-summary-section'}>
<EuiText size="xs">
<EuiPanel data-test-subj="query-details-summary-section">
<EuiTitle size="s">
<h2>No Data Available</h2>
</EuiText>
</EuiTitle>
</EuiPanel>
);
}
Expand All @@ -49,9 +56,9 @@ const QuerySummary = ({ query }: { query: SearchQueryRecord | null }) => {
const { timestamp, measurements, indices, search_type, node_id, total_shards } = query;
return (
<EuiPanel data-test-subj={'query-details-summary-section'}>
<EuiText size="xs">
<EuiTitle size="s">
<h2>Summary</h2>
</EuiText>
</EuiTitle>
<EuiHorizontalRule margin="m" />
<EuiFlexGrid columns={4}>
<PanelItem label={TIMESTAMP} value={convertTime(timestamp)} />
Expand Down
16 changes: 9 additions & 7 deletions public/pages/QueryDetails/QueryDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
EuiHorizontalRule,
EuiPanel,
EuiSpacer,
EuiText,
EuiTitle,
} from '@elastic/eui';
import { useHistory, useLocation } from 'react-router-dom';
Expand Down Expand Up @@ -143,12 +142,13 @@ const QueryDetails = ({
<EuiPanel data-test-subj={'query-details-source-section'}>
<EuiFlexGroup alignItems="center" justifyContent="spaceBetween">
<EuiFlexItem>
<EuiText size="xs">
<EuiTitle size="s">
<h2>Query</h2>
</EuiText>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
size="s"
iconSide="right"
iconType="popout"
target="_blank"
Expand All @@ -173,10 +173,12 @@ const QueryDetails = ({
</EuiFlexItem>
<EuiFlexItem grow={1} style={{ alignSelf: 'start' }}>
<EuiPanel data-test-subj={'query-details-latency-chart'}>
<EuiText size="xs">
<h2>Latency</h2>
</EuiText>
<EuiHorizontalRule margin="m" />
<EuiFlexItem>
<EuiTitle size="s">
<h2>Latency</h2>
</EuiTitle>
</EuiFlexItem>
<EuiHorizontalRule margin="xs" />
<div id="latency" />
</EuiPanel>
</EuiFlexItem>
Expand Down

0 comments on commit d8f62cf

Please sign in to comment.