Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Changed @Ignore to @AwaitsFix (#1245) #1272

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

kennyzhang0819
Copy link
Contributor

  • Changed @ignore to @AwaitsFix

  • added bugUrl


Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Changed @ignore to @AwaitsFix

Signed-off-by: Jinlin Zhang <[email protected]>

* added bugUrl

Signed-off-by: Jinlin Zhang <[email protected]>

---------

Signed-off-by: Jinlin Zhang <[email protected]>
@AWSHurneyt AWSHurneyt changed the title Changed @Ignore to @AwaitsFix (#1245) [Backport 2.x] Changed @Ignore to @AwaitsFix (#1245) Oct 30, 2023
@AWSHurneyt
Copy link
Collaborator

Manual backport of PR #1245

@AWSHurneyt
Copy link
Collaborator

@kennyzhang0819 could you rebase your dev branch for this PR? Looks like there were some fixes backported to the 2.x branch that should address some of these test failures.
944abf2

@kennyzhang0819
Copy link
Contributor Author

kennyzhang0819 commented Nov 4, 2023

@AWSHurneyt Hi I'm not sure if I did it right. I followed something like the following and now on my fork it says I need to create a new pull request.

git checkout backport-1245-to-2.x (the local branch name)
git fetch origin
git rebase origin/2.x
git push origin backport-1245-to-2.x --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants