Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Forbidden annotation org.junit.Ignore used instead of AwaitsFix #1244

Open
kennyzhang0819 opened this issue Oct 10, 2023 · 2 comments · Fixed by #1245
Open

[BUG] Forbidden annotation org.junit.Ignore used instead of AwaitsFix #1244

kennyzhang0819 opened this issue Oct 10, 2023 · 2 comments · Fixed by #1245
Labels
bug Something isn't working

Comments

@kennyzhang0819
Copy link
Contributor

Problem

  • ./gradlew build fails to run due to org.junit.Ignore being called in class SecureWorkflowRestApiIT.
  • Task :alerting:forbiddenApisTest FAILED Forbidden annotation use: org.junit.Ignore [Use AwaitsFix instead]

Solution

  • Use AwaitsFix Annotation Instead.
@AWSHurneyt
Copy link
Collaborator

AWSHurneyt commented Oct 13, 2023

Left this comment in the PR as well, but I'll add it here too for visibility. Once successfully backported, we can close this issue.

@kennyzhang0819 Looks like the auto backport for this PR failed. Could you please manually create a backport PR? To do that, you'd want to:

  1. Create a dev branch from the 2.x branch.
  2. Copy the changes from this PR to that branch (I usually use git cherry-pick to do this).
  3. Create a new PR from your 2.x dev branch to the 2.x branch in alerting repo.

@kennyzhang0819
Copy link
Contributor Author

Just did that. See #1272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants