feat(prices): allow users to submit category_tag with language prefix #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
force-pushed
the
category-tag-lang-prefix
branch
from
18bd9a0 to
a971bc7
Compare
raphodn
reviewed
Nov 6, 2024
raphodn
reviewed
Nov 7, 2024
raphodn
approved these changes
Nov 8, 2024
|
fyi i plan to refactor the save/clean/validation code, maybe move it to a seperate file, and document more the different rules : #553 |
raphodn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openfoodfacts/smooth-app#5553
edit: as discussed in the smooth-app issue, I introduced a change when it comes to
category_tag: we don't require anymore thecategory_tagto be valid with respect to the taxonomy.The goal is to prevent silent failure from price addition, as it's done in a background task.
This is also more aligned with Open Food Facts philosophy to accept data as it is, and built upon it using taxonomies (or correct it in the moderation stage).