-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add prices of products without barcode #5553
Comments
@raphael0202 We're blocked because in off-dart and Smoothie we're only able to autocomplete labels (e.g. |
@raphael0202 @teolemon Besides, that means we cannot do that offline one way or the other. |
I think it should be added to the autocomplete API on Product Opener. But we can definitely add support for language-specific tags on Open Prices side. |
@raphael0202 I don't know which solution is more pragmatic. Meanwhile, we're blocked here at Smoothie. |
It's definitely the Open Prices addition. It's on my todo list ;) |
@raphael0202 Cool! |
I think the retry strategy should really depend on the HTTP error code. In case of a 5XX error, it's definitely worth trying again later. If it's a 4XX, I think Smoothie should drop the task. And users can provide any category (even ones that don't exist in the taxonomy)?
That's an issue indeed, we should think about adding translations to the output response. |
Sounds fair, except that we don't provide any feedback in Smoothie about background tasks. The user thinks the price is added, and it'll never be. |
As agreed, I added support for language-specific categories in openfoodfacts/open-prices#548. We can now submit If the value is not recognized, we save it as-it. It's available in staging :) |
@raphael0202 Cool! |
@raphael0202 Tested this morning and it looks OK for |
You can add a space or not, both are supported! |
@raphael0202 Cool! Please ping me when you're done. |
@monsieurtanuki It's deployed in production :) |
@raphael0202 Both categories and origins in production, then. Thanks! |
fyi I created an issue - openfoodfacts/open-prices#575 - linked to this discussion : adding a new |
@raphodn Of course you know the impact of making this field mandatory: Smoothie wouldn't be able to create any price, unless all users upgrade their app after a new app version. That said, this field could be optional when creating a price, and computed (and checked) by Prices server anyway:
|
Update : the field (optional) is available in staging. And in production tomorrow. It'll be filled & returned for every price. |
Problem
Currently, we cannot add the price of a product without barcode (products such as fruit/vegetables that are sold per kg or per unit).
It would be great to add it!
For the record, it's available on the web version of Open Prices.
The text was updated successfully, but these errors were encountered: