Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Paragon past version 20 #650

Closed
wants to merge 2 commits into from
Closed

chore: update Paragon past version 20 #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f698608
fix(deps): update dependency universal-cookie to v4
renovate[bot] Dec 12, 2022
3a71ef2
chore: update Paragon past v20
cdeery Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
matrix:
npm-test:
- i18n_extract
- is-es5
- lint
- test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh. You know, maybe this isn't the right forum... but should we be requiring any of these test suites to pass before a PR can be merged? It doesn't look like we're requiring any of these today, but should be easy to add within GitHub (in the Branch Protection rules)

Copy link
Contributor

@justinhynes justinhynes Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(asking because I thought that we might need to remove the is-es5 tests as required in the Branch Protection settings)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a thinker... maybe a quick parking lot?

node: [16]
Expand Down
Loading