-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Paragon past version 20 #650
Conversation
Codecov ReportBase: 65.14% // Head: 65.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 47 47
Lines 809 809
Branches 156 156
=======================================
Hits 527 527
Misses 272 272
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b5f9206
to
3a71ef2
Compare
@@ -11,7 +11,6 @@ jobs: | |||
matrix: | |||
npm-test: | |||
- i18n_extract | |||
- is-es5 | |||
- lint | |||
- test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh. You know, maybe this isn't the right forum... but should we be requiring any of these test suites to pass before a PR can be merged? It doesn't look like we're requiring any of these today, but should be easy to add within GitHub (in the Branch Protection rules)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(asking because I thought that we might need to remove the is-es5
tests as required in the Branch Protection settings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a thinker... maybe a quick parking lot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -25,15 +25,14 @@ | |||
"access": "public" | |||
}, | |||
"browserslist": [ | |||
"last 2 versions", | |||
"ie 11" | |||
"extends @edx/browserslist-config" | |||
], | |||
"dependencies": { | |||
"@edx/brand": "npm:@edx/[email protected]", | |||
"@edx/frontend-component-footer": "11.6.0", | |||
"@edx/frontend-component-header": "3.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we un-pinning header / footer as part of this? Or follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to unpin it as a follow-up, because its managed in a different repo and it's easier to coordinate
Duplicate of #649 which has already been merged. |
Update paragon past v20 and any possible breaking changes
remove is-es5 dependency and update browserlist.