Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Paragon past version 20 #650

Closed
wants to merge 2 commits into from

Conversation

cdeery
Copy link

@cdeery cdeery commented Dec 13, 2022

Update paragon past v20 and any possible breaking changes
remove is-es5 dependency and update browserlist.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 65.14% // Head: 65.14% // No change to project coverage 👍

Coverage data is based on head (3a71ef2) compared to base (e507548).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   65.14%   65.14%           
=======================================
  Files          47       47           
  Lines         809      809           
  Branches      156      156           
=======================================
  Hits          527      527           
  Misses        272      272           
  Partials       10       10           
Impacted Files Coverage Δ
src/index.jsx 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cdeery cdeery force-pushed the cdeery/APER-2088/UpdateParagon branch from b5f9206 to 3a71ef2 Compare December 14, 2022 18:37
@@ -11,7 +11,6 @@ jobs:
matrix:
npm-test:
- i18n_extract
- is-es5
- lint
- test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh. You know, maybe this isn't the right forum... but should we be requiring any of these test suites to pass before a PR can be merged? It doesn't look like we're requiring any of these today, but should be easy to add within GitHub (in the Branch Protection rules)

Copy link
Contributor

@justinhynes justinhynes Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(asking because I thought that we might need to remove the is-es5 tests as required in the Branch Protection settings)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a thinker... maybe a quick parking lot?

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -25,15 +25,14 @@
"access": "public"
},
"browserslist": [
"last 2 versions",
"ie 11"
"extends @edx/browserslist-config"
],
"dependencies": {
"@edx/brand": "npm:@edx/[email protected]",
"@edx/frontend-component-footer": "11.6.0",
"@edx/frontend-component-header": "3.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we un-pinning header / footer as part of this? Or follow up

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to unpin it as a follow-up, because its managed in a different repo and it's easier to coordinate

@cdeery cdeery closed this Dec 15, 2022
@cdeery
Copy link
Author

cdeery commented Dec 15, 2022

Duplicate of #649 which has already been merged.

@justinhynes justinhynes deleted the cdeery/APER-2088/UpdateParagon branch January 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants