Fix/scroll position on exit from video fullscreen mode maple

[ihor-romaniuk]

This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.

Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.

Dependent PR to MFE Learning:
This MR openedx/edx-platform#31055 must be merged with this MR.

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (eac884b) 84.01% compared to head (8018989) 84.03%.

Additional details and impacted files

@@                      Coverage Diff                      @@
##           open-release/maple.master     #982      +/-   ##
=============================================================
+ Coverage                      84.01%   84.03%   +0.02%     
=============================================================
  Files                            226      226              
  Lines                           3986     3991       +5     
  Branches                        1015     1018       +3     
=============================================================
+ Hits                            3349     3354       +5     
  Misses                           615      615              
  Partials                          22       22              

Impacted Files	Coverage Δ
src/courseware/course/sequence/Unit.jsx	85.00% <100.00%> (+1.00%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[itsjeyd]

@ihor-romaniuk Thank you for your contribution! Please let us know when it is ready for review.

[ihor-romaniuk]

@itsjeyd It's ready for review. Thanks in advance.

[itsjeyd]

Hi @mattcarter, could we please get this PR lined up for engineering review by the Aurora team?

[itsjeyd]

@ProductRyan Since the corresponding edx-platform PR (openedx/edx-platform#31055) has been flagged for product review, I'm tentatively flagging this PR for product review as well.

If that's not necessary, please let me know.

CC @mphilbrick211

[itsjeyd]

Hey @jmakowski1123, you might already be aware of this PR but I'll CC you here (and on a few other PRs) just in case.

[itsjeyd]

For reference, going forward the primary communication place for PRs related to this issue will be #981 (as mentioned here).

[itsjeyd]

@ihor-romaniuk While #981 is going through product review, it might make sense to address failing codecov checks on this PR and #983. That way the changes would be ready for engineering review right after they get approval from product.

[jmakowski1123]

@mphilbrick211 I'm going to remove the "product review" label from this issue as the scope for this ticket is on code checks. Product review is underway on #981

[itsjeyd]

For reference, product review for this feature is happening via openedx/platform-roadmap#229.

[itsjeyd]

@ihor-romaniuk Just a quick heads-up, I'm updating labels on this PR again to indicate that it's waiting for additional changes addressing codecov failures.

[ihor-romaniuk]

Hi @itsjeyd. Sorry for delay. Tests were updated and it's ready for review.

[itsjeyd]

Thanks @ihor-romaniuk, I posted on the main PR (#983) to get the changes lined up for engineering review.

[itsjeyd]

Note on current status: Main PR has been added to review queue.

[leangseu-edx]

Why is package-lock.json change? I think you should revert the file.

[itsjeyd]

Hey @ihor-romaniuk, a friendly reminder to address @leangseu-edx's comment above so we can get this backport merged :)

[ihor-romaniuk]

Hi @leangseu-edx @itsjeyd
Everything was fixed. Please take a look one more.

[itsjeyd]

Thanks @ihor-romaniuk, looks like we should be able to get this over the line very soon.

[itsjeyd]

Hey @leangseu-edx, friendly ping about having a quick look at this PR. It's a backport of another PR (#983) that you recently reviewed and merged.

[leangseu-edx]

Hey @leangseu-edx, friendly ping about having a quick look at this PR. It's a backport of another PR (#983) that you recently reviewed and merged.

This is a pair pr with openedx/edx-platform#31055. Due to the other pr if failing, I am uncomfortable merging it.

[itsjeyd]

@leangseu-edx OK I see, thanks for the info.

[ihor-romaniuk]

Closed due to outdated edx version and no need for these changes.
Related MR also closed openedx/edx-platform#31055.

[openedx-webhooks]

@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.