Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [RGOeX-1240] save scroll position on exit from fullscreen #559

Conversation

ihor-romaniuk
Copy link

@ihor-romaniuk ihor-romaniuk commented Oct 3, 2022

Description: save scroll position on exit from video xblock fullscreen mode

Youtrack: https://youtrack.raccoongang.com/issue/RGOeX-1240

Note:
This PR should be merged after merging the corresponding PR in upstream MEF repos
[maple MFE Learning] openedx/frontend-app-learning#982
[nutmeg MFE Learning] openedx/frontend-app-learning#981
[master MFE Learning] openedx/frontend-app-learning#983

Copy link
Collaborator

@idegtiarov idegtiarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but two minor nits are mentioned in the comments inline. Please take a look.

video_xblock/backends/base.py Outdated Show resolved Hide resolved
video_xblock/backends/brightcove.py Outdated Show resolved Hide resolved
@idegtiarov idegtiarov merged commit 71b2a27 into master Oct 3, 2022
@idegtiarov idegtiarov deleted the romaniuk/RGOeX-1240/fix/scroll-position-on-exit-from-video-fullscreen-mode branch October 3, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants