Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save scroll position on exit from video xblock fullscreen mode #1077

Conversation

ihor-romaniuk
Copy link
Contributor

This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.

Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.

Dependent PR to MFE Learning:
This MR openedx/edx-platform#31871 must be merged with this MR.

All general discussion and addition information there: openedx/platform-roadmap#229

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/olive.master@5dab087). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/olive.master    #1077   +/-   ##
============================================================
  Coverage                             ?   84.37%           
============================================================
  Files                                ?      264           
  Lines                                ?     4563           
  Branches                             ?     1181           
============================================================
  Hits                                 ?     3850           
  Misses                               ?      693           
  Partials                             ?       20           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmakowski1123
Copy link

Thanks for mentioning the main Feature Ticket in the description, @ihor-romaniuk !
@mphilbrick211 This is another PR related to openedx/platform-roadmap#229

@jmakowski1123 jmakowski1123 added the product review PR requires product review before merging label Mar 3, 2023
@ihor-romaniuk
Copy link
Contributor Author

Hi @itsjeyd. Sorry for delay. Tests were updated and it's ready for review.

@itsjeyd
Copy link

itsjeyd commented May 9, 2023

Thanks @ihor-romaniuk, I posted on the main PR (#983) to get the changes lined up for engineering review.

@itsjeyd
Copy link

itsjeyd commented May 31, 2023

Note on current status: Main PR has been added to review queue.

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leangseu-edx leangseu-edx merged commit 5d8dccd into openedx:open-release/olive.master Jun 21, 2023
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants