-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save scroll position on exit from video xblock fullscreen mode #1077
fix: save scroll position on exit from video xblock fullscreen mode #1077
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #1077 +/- ##
============================================================
Coverage ? 84.37%
============================================================
Files ? 264
Lines ? 4563
Branches ? 1181
============================================================
Hits ? 3850
Misses ? 693
Partials ? 20 ☔ View full report in Codecov by Sentry. |
Thanks for mentioning the main Feature Ticket in the description, @ihor-romaniuk ! |
Hi @itsjeyd. Sorry for delay. Tests were updated and it's ready for review. |
Thanks @ihor-romaniuk, I posted on the main PR (#983) to get the changes lined up for engineering review. |
Note on current status: Main PR has been added to review queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.
A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.
Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.
Dependent PR to MFE Learning:
This MR openedx/edx-platform#31871 must be merged with this MR.
All general discussion and addition information there: openedx/platform-roadmap#229