-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save scroll position on exit from video xblock fullscreen mode #31871
fix: save scroll position on exit from video xblock fullscreen mode #31871
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for mentioning the main Feature Ticket in the description, @ihor-romaniuk ! |
4/5/23 - Product review complete. @openedx/content-aurora @mattcarter - is this something you can take a look at for review / merge? This PR is related to the other "scroll position" PRs listed here: #31053. |
Friendly ping on this :) @mattcarter - is this something you can take a look at for review / merge? This PR is related to the other "scroll position" PRs listed #31053 (comment): #31053. CC: @openedx/content-aurora |
Just re-flagging this, @openedx/content-aurora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks, @leangseu-edx! Do you know if someone from your team can merge this? |
I will merge it this afternoon. |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.
A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.
Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.
Dependent PR to MFE Learning:
This MR openedx/frontend-app-learning#1077 must be merged with this MR.
All general discussion and addition information there: openedx/platform-roadmap#229