Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use modifyObjectKeys and snakeCaseObject on api data advanced settings to format values #1581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jignaciopm
Copy link

Description

This PR fixes this bug and this bug.

Testing instructions

  • Deploy your local environment or go to your preferred remote environment (REDWOOD).
  • Go to studio > settings > advanced settings.
  • "Certificate html override" and "other course settings" are showing dictionary keys in camelCase (Review any field whose value is an object with configuration keys).

BEFORE
Captura de pantalla de 2024-12-30 19-41-49
Captura de pantalla de 2024-12-30 19-41-41

AFTER
Captura de pantalla de 2024-12-30 19-41-10

@jignaciopm jignaciopm requested a review from a team as a code owner January 3, 2025 04:39
@openedx-webhooks
Copy link

Thanks for the pull request, @jignaciopm!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jignaciopm jignaciopm force-pushed the jipm/fix-setting-snake-case branch from 42e21ab to 3cb49ce Compare January 3, 2025 19:35
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 3, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (dc0ba6a) to head (3cb49ce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files        1075     1075           
  Lines       21205    21213    +8     
  Branches     4562     4492   -70     
=======================================
+ Hits        19715    19723    +8     
  Misses       1424     1424           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 7, 2025
@mphilbrick211 mphilbrick211 requested review from a team and removed request for a team January 7, 2025 14:45
igobranco pushed a commit to fccn/frontend-app-authoring that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants