[BUG] The advanced settings editor mangles the values passed to "OTHER_COURSE_SETTINGS"

[felipemontoya]

I found a hidden behavior in the advanced settings editor that I think is very damaging to extension builders.

where

This was tested in a tutor-nightly environment created today.

There is a setting called "Other course settings" that is turned off by default. It requires that one sets:

FEATURES["ENABLE_OTHER_COURSE_SETTINGS"] = True

In the non mfe-editor it looks like this

In the MFE version, it is present when the FEATURE is on. It looks a bit different, but that is not an issue:

what

The real issue is that it mangles the data.
If I save this:

It becomes:

Basically the editor, turned CONSTANT_CASE into camelCase.

The API returned the original CONSTANT_CASE:

But the rendered changed it.

If I edit the box again and save, the values will be updated at the backend in the mangled state.

[bra-i-am]

hi, here is the place where the keys are shifted to camelCase and the behavior is happening with absolutely all the keys even if they are inside an Array

https://github.com/openedx/frontend-app-course-authoring/blob/735d978894c2548b1af21cb32d508b091182e692/src/advanced-settings/data/api.js#L18

[felipemontoya]

Hi @PKulkoRaccoonGang, do you know if there was a requirement for the camelCase transformation?

The quick fix would be to exclude the other_course_settings from the camelCase cast, however this might be impacting other settings as well that expect a specific value in the backend.

[igobranco]

Hi, this problem is also impacting our NAU platform. Anyone knows why this have been implemented?

[bradenmacdonald]

I think it's simply an accidental bug. Looks like #1581 is the fix.