Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0036] feat: Tag sections, subsections, and the whole course #34690

Conversation

yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented May 3, 2024

Description

This PR adds the ability to tag the whole course, sections and subsections.

Screenshot 2024-05-05 at 7 18 15 PM

Supporting information

Related Tickets:

Testing instructions

  1. Run this branch in your devstack/tutor
  2. Make sure you have new_studio_mfe.use_tagging_taxonomy_list_page waffle flag enabled
  3. Make sure you can access the legacy studio (non-mfe) page. You may need to disable some mfe related flags if you have them set
  4. Make sure you have sample tags/taxonomies setup
  5. Make sure to rebuild assets: tutor dev exec lms openedx-assets build --env=dev
  6. Click on a course to enter the course outline page
  7. You should see Manage tags for the course similar to the screenshot above, click on it, the tags drawer should open, add/remove tags, it should update the count on the page automatically
  8. Similarly do the same for Sections and Subsections

Private-ref: FAL-3735

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 3, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 3, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh changed the title [FC-0036] feat: Add course tags count/manage for course [FC-0036] feat: Tag sections, subsections, and the whole course May 3, 2024
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/tags-course-sections-subsections branch from 0b0bdca to 37343e0 Compare May 3, 2024 18:19
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/tags-course-sections-subsections branch from 37343e0 to 2c5b99e Compare May 5, 2024 15:59
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/tags-course-sections-subsections branch from 2c5b99e to 5f5f3a1 Compare May 6, 2024 10:43
@yusuf-musleh yusuf-musleh marked this pull request as ready for review May 6, 2024 11:15
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good 👍

  • I tested this: I followed the testing instructions and I verified that the counts are updated when tags changed
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).

@bradenmacdonald bradenmacdonald merged commit a3924f6 into openedx:master May 7, 2024
109 checks passed
@bradenmacdonald bradenmacdonald deleted the yusuf-musleh/tags-course-sections-subsections branch May 7, 2024 17:29
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

andrey-canon pushed a commit to nelc/edx-platform that referenced this pull request May 16, 2024
(In the legacy UI, if the 'new_studio_mfe.use_tagging_taxonomy_list_page' waffle flag is enabled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Tagging] Legacy UI: Tag sections, subsections, and the whole course
5 participants