Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And/backport tag course #28

Merged
merged 2 commits into from
May 21, 2024

Conversation

andrey-canon
Copy link
Collaborator

Description

The first commit is a backport of openedx#34059 that basically that is a refactor since that depends on https://github.com/openedx/frontend-app-course-authoring/pull/800/files and that was closed

Second commint is a backport of openedx#34690 that allows to tag the whole course sections and subsections

Testing instructions

  1. Compile js openedx-assets webpack --env=prod
  2. Compile styles openedx-assets common
  3. Play around creating tags

image

@andrey-canon andrey-canon force-pushed the and/backport_tag_course branch 2 times, most recently from dc18660 to d8ecd44 Compare May 9, 2024 23:41
@andrey-canon andrey-canon requested a review from johanseto May 10, 2024 14:07
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to deal a lot with compiling statics. Or restarting docker container or maybe is a cache for js underscore.
After that shows as expected. Also API saving in model.
Peek 2024-05-10 18-04

@johanseto johanseto self-requested a review May 10, 2024 23:08
@andrey-canon andrey-canon force-pushed the and/backport_count_in_components branch from 1367cb2 to b57535c Compare May 16, 2024 15:41
ChrisChV and others added 2 commits May 16, 2024 18:43
* style: drawer-cover color updated for all tagging drawers
* feat: Update TagList component when a tag is updated on Manage tags drawer
* feat: Refactor TagCount to be able to refresh the count
* feat: Sync tag count in units
(In the legacy UI, if the 'new_studio_mfe.use_tagging_taxonomy_list_page' waffle flag is enabled)
@andrey-canon andrey-canon force-pushed the and/backport_tag_course branch from d8ecd44 to 4e855ee Compare May 16, 2024 23:43
@andrey-canon andrey-canon changed the base branch from and/backport_count_in_components to open-release/palm.nelp May 16, 2024 23:43
@andrey-canon andrey-canon merged commit 91a8b31 into open-release/palm.nelp May 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants